Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2333573003: //device/media_transfer_protocol depends on dbus (Closed)

Created:
4 years, 3 months ago by Mostyn Bramley-Moore
Modified:
4 years, 3 months ago
Reviewers:
brettw, mbjorge
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//device/media_transfer_protocol depends on dbus The build should fail early if //device/media_transfer_protocol is included with dbus explicitly disabled. BUG=632297 Committed: https://crrev.com/e5c9431b0a1d8714ecf2fe2659f740e5d2d61201 Cr-Commit-Position: refs/heads/master@{#418744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Mostyn Bramley-Moore
@brettw: please take a look. @mbjorge: is this OK for downstream chromecast builds?
4 years, 3 months ago (2016-09-12 12:28:14 UTC) #7
mbjorge
On 2016/09/12 at 12:28:14, mostynb wrote: > @mbjorge: is this OK for downstream chromecast builds? ...
4 years, 3 months ago (2016-09-13 20:59:30 UTC) #9
mbjorge
On 2016/09/13 at 20:59:30, mbjorge wrote: > On 2016/09/12 at 12:28:14, mostynb wrote: > > ...
4 years, 3 months ago (2016-09-13 20:59:54 UTC) #10
Mostyn Bramley-Moore
np :) @brettw: *ping* (not sure which IM to ping you on, I can't see ...
4 years, 3 months ago (2016-09-13 22:44:29 UTC) #11
brettw
lgtm
4 years, 3 months ago (2016-09-14 22:46:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333573003/1
4 years, 3 months ago (2016-09-14 22:55:23 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 01:22:56 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 01:24:30 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5c9431b0a1d8714ecf2fe2659f740e5d2d61201
Cr-Commit-Position: refs/heads/master@{#418744}

Powered by Google App Engine
This is Rietveld 408576698