Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2333533003: Add a |contentEquals| method to cursors and ranges. (Closed)

Created:
4 years, 3 months ago by David Tseng
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a |contentEquals| method to cursors and ranges. Define the |contentEquals| comparison on cursors and ranges as positions or selections in the document that can be considered loosely equal. This allows any event requiring ChromeVox to make decisions about equivalent ranges to be more strict. BUG=641755, 641787, 641756 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cee1e04d19db477182819412a83d52b266a82cbb Cr-Commit-Position: refs/heads/master@{#419639}

Patch Set 1 #

Patch Set 2 : Add a |contentEquals| method to cursors and ranges. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js View 4 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
David Tseng
4 years, 3 months ago (2016-09-12 18:34:16 UTC) #4
David Tseng
Friendly ping
4 years, 3 months ago (2016-09-19 19:51:57 UTC) #7
dmazzoni
lgtm
4 years, 3 months ago (2016-09-19 20:11:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333533003/20001
4 years, 3 months ago (2016-09-20 00:27:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 01:50:56 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:53:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cee1e04d19db477182819412a83d52b266a82cbb
Cr-Commit-Position: refs/heads/master@{#419639}

Powered by Google App Engine
This is Rietveld 408576698