Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2353)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync @269781 + 'autlock'->'autolock' from erik's comment that was not included before Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/prerender/prerender_cookie.html ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
===================================================================
--- content/browser/renderer_host/render_process_host_impl.cc (revision 269781)
+++ content/browser/renderer_host/render_process_host_impl.cc (working copy)
@@ -1716,11 +1716,12 @@
iterator iter(AllHostsIterator());
while (!iter.IsAtEnd()) {
- if (RenderProcessHostImpl::IsSuitableHost(
+ if (GetContentClient()->browser()->MayReuseHost(iter.GetCurrentValue()) &&
+ RenderProcessHostImpl::IsSuitableHost(
iter.GetCurrentValue(),
- browser_context, site_url))
+ browser_context, site_url)) {
suitable_renderers.push_back(iter.GetCurrentValue());
-
+ }
iter.Advance();
}
@@ -1773,7 +1774,8 @@
std::string site = SiteInstance::GetSiteForURL(browser_context, url)
.possibly_invalid_spec();
RenderProcessHost* host = map->FindProcess(site);
- if (host && !IsSuitableHost(host, browser_context, url)) {
+ if (host && (!GetContentClient()->browser()->MayReuseHost(host) ||
+ !IsSuitableHost(host, browser_context, url))) {
// The registered process does not have an appropriate set of bindings for
// the url. Remove it from the map so we can register a better one.
RecordAction(
« no previous file with comments | « chrome/test/data/prerender/prerender_cookie.html ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698