Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync @269781 + 'autlock'->'autolock' from erik's comment that was not included before Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
===================================================================
--- chrome/browser/ui/search/instant_search_prerenderer_unittest.cc (revision 269781)
+++ chrome/browser/ui/search/instant_search_prerenderer_unittest.cc (working copy)
@@ -59,7 +59,8 @@
virtual void StartPrerendering(
int ALLOW_UNUSED creator_child_id,
const gfx::Size& ALLOW_UNUSED size,
- content::SessionStorageNamespace* session_storage_namespace) OVERRIDE;
+ content::SessionStorageNamespace* session_storage_namespace,
+ net::URLRequestContextGetter* request_context) OVERRIDE;
virtual bool GetChildId(int* child_id) const OVERRIDE;
virtual bool GetRouteId(int* route_id) const OVERRIDE;
@@ -115,7 +116,8 @@
void DummyPrerenderContents::StartPrerendering(
int ALLOW_UNUSED creator_child_id,
const gfx::Size& ALLOW_UNUSED size,
- content::SessionStorageNamespace* session_storage_namespace) {
+ content::SessionStorageNamespace* session_storage_namespace,
+ net::URLRequestContextGetter* request_context) {
prerender_contents_.reset(content::WebContents::CreateWithSessionStorage(
content::WebContents::CreateParams(profile_),
session_storage_namespace_map_));
@@ -181,7 +183,8 @@
SetPrerenderContentsFactory(
new DummyPrerenderContentsFactory(call_did_finish_load,
session_storage_namespace_map));
-
+ PrerenderManagerFactory::GetForProfile(browser()->profile())->
+ OnCookieStoreLoaded();
if (prerender_search_results_base_page) {
InstantSearchPrerenderer* prerenderer = GetInstantSearchPrerenderer();
prerenderer->Init(session_storage_namespace_map, gfx::Size(640, 480));
« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698