Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/prerender/prerender_unittest.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync @269781 + 'autlock'->'autolock' from erik's comment that was not included before Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_tracker.cc ('k') | chrome/browser/profiles/profile_io_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_unittest.cc
===================================================================
--- chrome/browser/prerender/prerender_unittest.cc (revision 269781)
+++ chrome/browser/prerender/prerender_unittest.cc (working copy)
@@ -52,7 +52,8 @@
virtual void StartPrerendering(
int ALLOW_UNUSED creator_child_id,
const gfx::Size& ALLOW_UNUSED size,
- content::SessionStorageNamespace* ALLOW_UNUSED session_storage_namespace)
+ content::SessionStorageNamespace* ALLOW_UNUSED session_storage_namespace,
+ net::URLRequestContextGetter* ALLOW_UNUSED request_context)
OVERRIDE;
virtual bool GetChildId(int* child_id) const OVERRIDE {
@@ -101,6 +102,7 @@
time_ticks_(TimeTicks::Now()),
prerender_tracker_(prerender_tracker) {
set_rate_limit_enabled(false);
+ OnCookieStoreLoaded();
}
virtual ~UnitTestPrerenderManager() {
@@ -229,6 +231,11 @@
prerender_contents_map_.erase(std::make_pair(child_id, route_id));
}
+ protected:
+ virtual net::URLRequestContextGetter* GetURLRequestContext() OVERRIDE {
+ return NULL;
+ }
+
private:
void SetNextPrerenderContents(DummyPrerenderContents* prerender_contents) {
CHECK(!next_prerender_contents_.get());
@@ -296,7 +303,8 @@
void DummyPrerenderContents::StartPrerendering(
int ALLOW_UNUSED creator_child_id,
const gfx::Size& ALLOW_UNUSED size,
- content::SessionStorageNamespace* ALLOW_UNUSED session_storage_namespace) {
+ content::SessionStorageNamespace* ALLOW_UNUSED session_storage_namespace,
+ net::URLRequestContextGetter* ALLOW_UNUSED request_context) {
// In the base PrerenderContents implementation, StartPrerendering will
// be called even when the PrerenderManager is part of the control group,
// but it will early exit before actually creating a new RenderView if
« no previous file with comments | « chrome/browser/prerender/prerender_tracker.cc ('k') | chrome/browser/profiles/profile_io_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698