Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3147)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync @269781 + 'autlock'->'autolock' from erik's comment that was not included before Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java
===================================================================
--- chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java (revision 269781)
+++ chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java (working copy)
@@ -21,11 +21,14 @@
* Tests for adding and removing prerenders using the {@link ExternalPrerenderHandler}
*/
public class ExternalPrerenderRequestTest extends ChromeShellTestBase {
+ private static final String HOMEPAGE_URL =
+ TestHttpServerClient.getUrl("chrome/test/data/android/prerender/homepage.html");
private static final String GOOGLE_URL =
TestHttpServerClient.getUrl("chrome/test/data/android/prerender/google.html");
private static final String YOUTUBE_URL =
TestHttpServerClient.getUrl("chrome/test/data/android/prerender/youtube.html");
private static final int PRERENDER_DELAY_MS = 500;
+ private static final int CHECK_COOKIE_STORE_FREQUENCY_MS = 200;
private ExternalPrerenderHandler mHandler;
private Profile mProfile;
@@ -34,7 +37,8 @@
public void setUp() throws Exception {
super.setUp();
clearAppData();
- launchChromeShellWithBlankPage();
+ // Launch with a non-blank homepage, to trigger cookie store loading.
+ launchChromeShellWithUrl(HOMEPAGE_URL);
assertTrue(waitForActiveShellToBeDoneLoading());
mHandler = new ExternalPrerenderHandler();
final Callable<Profile> profileCallable = new Callable<Profile>() {
@@ -44,6 +48,8 @@
}
};
mProfile = ThreadUtils.runOnUiThreadBlocking(profileCallable);
+ while (!ExternalPrerenderHandler.hasCookieStoreLoaded(mProfile))
+ Thread.sleep(CHECK_COOKIE_STORE_FREQUENCY_MS);
}
@MediumTest

Powered by Google App Engine
This is Rietveld 408576698