chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc - Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

===================================================================

--- chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc (revision 265252)

+++ chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc (working copy)

@@ -398,6 +398,13 @@

prerender::PrerenderManager* prerender_manager =

prerender::PrerenderManagerFactory::GetForProfile(profile);

prerender_manager->mutable_config().max_bytes = 1000 * 1024 * 1024;

+ if (!prerender_manager->cookie_store_loaded()) {

+ prerender_manager->set_on_cookie_store_loaded_cb(

+ base::Bind(

+ &base::MessageLoop::Quit,

+ base::Unretained(base::MessageLoop::current())));

+ base::MessageLoop::current()->Run();

+ }

}

content::WebUIMessageHandler* NetInternalsTest::GetMockMessageHandler() {