chrome/test/data/prerender/prerender_cookie.html - Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_cookie.html

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <meta http-equiv="expires" content="0">

	3 <script src="prerender_events_common.js"></script>

	4 <script>

	5 function GetCookie(cookieName) {

	6 var re = RegExp(cookieName + '=([^;]*)');

	7 var result = re.exec(document.cookie);

	8 if (result)

	9 return result[1];

	10 return "";

	11 }

	12

	13 function SetCookie(cookieName, cookieValue) {

	14 var exp = "Tue, 31 Dec 2030 23:59:59 GMT";

	15 if (cookieValue == "")

	16 exp = "Thu, 01 Jan 1970 00:00:00 GMT";

	17 document.cookie = cookieName + "=" + cookieValue + "; expires=" + exp;

	18 }

	19

	20 if (ExtractGetParameterBadlyAndInsecurely('set', 0) != 0) {

	21 var cookieName = ExtractGetParameterBadlyAndInsecurely('key', "");

	22 var cookieValue = ExtractGetParameterBadlyAndInsecurely('value', "");

	23 SetCookie(cookieName, cookieValue);

	24 }

	25

	26 document.write(document.cookie);

	27

	28 </script>

	29 <body></body></html>

OLD	NEW