Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/profiles/profile_io_data.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/profile_io_data.h" 5 #include "chrome/browser/profiles/profile_io_data.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 user->username_hash(), 360 user->username_hash(),
361 profile->GetPath(), 361 profile->GetPath(),
362 is_primary_user)); 362 is_primary_user));
363 } 363 }
364 } 364 }
365 if (params->username_hash.empty()) 365 if (params->username_hash.empty())
366 LOG(WARNING) << "no username_hash"; 366 LOG(WARNING) << "no username_hash";
367 #endif 367 #endif
368 368
369 params->profile = profile; 369 params->profile = profile;
370 params->prerender_tracker = g_browser_process->prerender_tracker();
370 profile_params_.reset(params.release()); 371 profile_params_.reset(params.release());
371 372
372 ChromeNetworkDelegate::InitializePrefsOnUIThread( 373 ChromeNetworkDelegate::InitializePrefsOnUIThread(
373 &enable_referrers_, 374 &enable_referrers_,
374 &enable_do_not_track_, 375 &enable_do_not_track_,
375 &force_safesearch_, 376 &force_safesearch_,
376 pref_service); 377 pref_service);
377 378
378 scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy = 379 scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy =
379 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO); 380 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO);
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
938 network_delegate->set_extension_info_map( 939 network_delegate->set_extension_info_map(
939 profile_params_->extension_info_map.get()); 940 profile_params_->extension_info_map.get());
940 #if defined(ENABLE_CONFIGURATION_POLICY) 941 #if defined(ENABLE_CONFIGURATION_POLICY)
941 network_delegate->set_url_blacklist_manager(url_blacklist_manager_.get()); 942 network_delegate->set_url_blacklist_manager(url_blacklist_manager_.get());
942 #endif 943 #endif
943 network_delegate->set_profile(profile_params_->profile); 944 network_delegate->set_profile(profile_params_->profile);
944 network_delegate->set_profile_path(profile_params_->path); 945 network_delegate->set_profile_path(profile_params_->path);
945 network_delegate->set_cookie_settings(profile_params_->cookie_settings.get()); 946 network_delegate->set_cookie_settings(profile_params_->cookie_settings.get());
946 network_delegate->set_enable_do_not_track(&enable_do_not_track_); 947 network_delegate->set_enable_do_not_track(&enable_do_not_track_);
947 network_delegate->set_force_google_safe_search(&force_safesearch_); 948 network_delegate->set_force_google_safe_search(&force_safesearch_);
949 network_delegate->set_prerender_tracker(profile_params_->prerender_tracker);
948 network_delegate_.reset(network_delegate); 950 network_delegate_.reset(network_delegate);
949 951
950 fraudulent_certificate_reporter_.reset( 952 fraudulent_certificate_reporter_.reset(
951 new chrome_browser_net::ChromeFraudulentCertificateReporter( 953 new chrome_browser_net::ChromeFraudulentCertificateReporter(
952 main_request_context_.get())); 954 main_request_context_.get()));
953 955
954 // NOTE: Proxy service uses the default io thread network delegate, not the 956 // NOTE: Proxy service uses the default io thread network delegate, not the
955 // delegate just created. 957 // delegate just created.
956 proxy_service_.reset( 958 proxy_service_.reset(
957 ProxyServiceFactory::CreateProxyService( 959 ProxyServiceFactory::CreateProxyService(
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
1167 void ProfileIOData::SetCookieSettingsForTesting( 1169 void ProfileIOData::SetCookieSettingsForTesting(
1168 CookieSettings* cookie_settings) { 1170 CookieSettings* cookie_settings) {
1169 DCHECK(!cookie_settings_.get()); 1171 DCHECK(!cookie_settings_.get());
1170 cookie_settings_ = cookie_settings; 1172 cookie_settings_ = cookie_settings;
1171 } 1173 }
1172 1174
1173 void ProfileIOData::set_signin_names_for_testing( 1175 void ProfileIOData::set_signin_names_for_testing(
1174 SigninNamesOnIOThread* signin_names) { 1176 SigninNamesOnIOThread* signin_names) {
1175 signin_names_.reset(signin_names); 1177 signin_names_.reset(signin_names);
1176 } 1178 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698