Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/prerender/prerender_final_status.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_final_status.h" 5 #include "chrome/browser/prerender/prerender_final_status.h"
6 6
7 #include "chrome/browser/prerender/prerender_manager.h" 7 #include "chrome/browser/prerender/prerender_manager.h"
8 8
9 namespace prerender { 9 namespace prerender {
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 "Match Complete Dummy", 52 "Match Complete Dummy",
53 "Duplicate", 53 "Duplicate",
54 "OpenURL", 54 "OpenURL",
55 "WouldHaveBeenUsed", 55 "WouldHaveBeenUsed",
56 "Register Protocol Handler", 56 "Register Protocol Handler",
57 "Creating Audio Stream", 57 "Creating Audio Stream",
58 "Page Being Captured", 58 "Page Being Captured",
59 "Bad Deferred Redirect", 59 "Bad Deferred Redirect",
60 "Navigation Uncommitted", 60 "Navigation Uncommitted",
61 "New Navigation Entry", 61 "New Navigation Entry",
62 "Cookie Store Not Loaded",
63 "Cookie Conflict",
62 "Max", 64 "Max",
63 }; 65 };
64 COMPILE_ASSERT(arraysize(kFinalStatusNames) == FINAL_STATUS_MAX + 1, 66 COMPILE_ASSERT(arraysize(kFinalStatusNames) == FINAL_STATUS_MAX + 1,
65 PrerenderFinalStatus_name_count_mismatch); 67 PrerenderFinalStatus_name_count_mismatch);
66 68
67 } // namespace 69 } // namespace
68 70
69 const char* NameFromFinalStatus(FinalStatus final_status) { 71 const char* NameFromFinalStatus(FinalStatus final_status) {
70 DCHECK_LT(static_cast<unsigned int>(final_status), 72 DCHECK_LT(static_cast<unsigned int>(final_status),
71 arraysize(kFinalStatusNames)); 73 arraysize(kFinalStatusNames));
72 return kFinalStatusNames[final_status]; 74 return kFinalStatusNames[final_status];
73 } 75 }
74 76
75 } // namespace prerender 77 } // namespace prerender
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698