Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2333513003: Fix GraphicsLayer under-invalidation checking when interest rect changes (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GraphicsLayer under-invalidation checking when interest rect changes We should not check under-invalidation out of either the previous interest rect or the current interest rect. BUG=619103 Committed: https://crrev.com/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3 Cr-Commit-Position: refs/heads/master@{#418057}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : - #

Messages

Total messages: 23 (16 generated)
Xianzhu
4 years, 3 months ago (2016-09-12 18:01:59 UTC) #5
Xianzhu
Sorry, just found a bug in the CL. Fixing it.
4 years, 3 months ago (2016-09-12 18:25:41 UTC) #7
Xianzhu
It's good now. Ptal.
4 years, 3 months ago (2016-09-12 19:13:49 UTC) #12
chrishtr
lgtm
4 years, 3 months ago (2016-09-12 21:04:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333513003/60001
4 years, 3 months ago (2016-09-12 21:35:34 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-12 21:43:43 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 21:46:28 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3
Cr-Commit-Position: refs/heads/master@{#418057}

Powered by Google App Engine
This is Rietveld 408576698