Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2333483002: Remove deprecated version of PaymentResponse::ToDictionaryValue. (Closed)

Created:
4 years, 3 months ago by Justin Donnelly
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated version of PaymentResponse::ToDictionaryValue. This is no longer in use as of https://chromereviews.googleplex.com/494267014/. BUG=602666 Committed: https://crrev.com/6ef0b712fbac1495d26f8f3e8d13f13d4f90e9b7 Cr-Commit-Position: refs/heads/master@{#417963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ios/web/payments/payment_request.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/public/payments/payment_request.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Justin Donnelly
4 years, 3 months ago (2016-09-10 18:48:36 UTC) #6
Evan Stade
lgtm
4 years, 3 months ago (2016-09-12 14:55:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333483002/1
4 years, 3 months ago (2016-09-12 14:59:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/257499)
4 years, 3 months ago (2016-09-12 15:05:06 UTC) #11
Justin Donnelly
+eugenebut for OWNERS review
4 years, 3 months ago (2016-09-12 16:52:05 UTC) #13
Eugene But (OOO till 7-30)
lgtm
4 years, 3 months ago (2016-09-12 17:01:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333483002/1
4 years, 3 months ago (2016-09-12 17:13:27 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 17:17:35 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 17:21:19 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ef0b712fbac1495d26f8f3e8d13f13d4f90e9b7
Cr-Commit-Position: refs/heads/master@{#417963}

Powered by Google App Engine
This is Rietveld 408576698