Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: base/unguessable_token.h

Issue 2333443002: Add base::UnguessableToken (Closed)
Patch Set: Name change. CHECK --> DCHECK Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/unguessable_token.h
diff --git a/base/unguessable_token.h b/base/unguessable_token.h
new file mode 100644
index 0000000000000000000000000000000000000000..d33da169d43c87bdd7499dcefcb50bc28b7257eb
--- /dev/null
+++ b/base/unguessable_token.h
@@ -0,0 +1,93 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_UNGUESSABLE_TOKEN_H_
+#define BASE_UNGUESSABLE_TOKEN_H_
+
+#include <stdint.h>
+#include <string.h>
+#include <tuple>
+
+#include "base/base_export.h"
+#include "base/hash.h"
+#include "base/logging.h"
+
+namespace base {
+
+struct UnguessableTokenHash;
+
+// A UnguessableToken is an 128-bit token generated from a cryptographically
+// strong random source.
+//
+// UnguessableToken should be used when a sensitive ID needs to be unguessable,
+// and is shared across processes. It can be used as part of a larger aggregate
+// type, or as an ID in and of itself.
+//
+// Use Create() for creating new UnguessableTokens.
+//
+// NOTE: It is illegal to send empty UnguessableTokens across processes, and
+// sending/receiving empty tokens should be treated as a security issue.
+// If there is a valid scenario for sending "no token" across processes,
+// base::Optional should be used instead of an empty token.
+class BASE_EXPORT UnguessableToken {
+ public:
+ // Create a unique UnguessableToken.
+ static UnguessableToken Create();
+
+ // Return a UnguessableToken built from the high/low bytes provided.
+ // It should only be used in deserialization scenarios.
+ //
+ // NOTE: If the deserialized token is empty, it means that it was never
+ // initialized via Create(). This is a security issue, and should be handled.
+ static UnguessableToken Deserialize(uint64_t high, uint64_t low);
+
+ // Creates an empty UnguessableToken.
+ // Assign to it with Create() before using it.
+ UnguessableToken() = default;
+
+ // Return |high_| and |low_| as out parameters.
+ // NOTE: Serializing an empty UnguessableToken is an illegal operation.
+ void Serialize(uint64_t* high_out, uint64_t* low_out) const;
+
+ bool is_empty() const { return high_ == 0 && low_ == 0; }
+
+ std::string ToString() const;
+
+ explicit operator bool() const { return !is_empty(); }
+
+ bool operator<(const UnguessableToken& other) const {
+ return std::tie(high_, low_) < std::tie(other.high_, other.low_);
+ }
+
+ bool operator==(const UnguessableToken& other) const {
+ // Based on crypto::SecureMemEqual().
sandersd (OOO until July 31) 2016/09/16 22:13:55 I am still opposed to suggesting that the implemen
danakj 2016/09/16 22:21:35 I'm super fine with just doing high==other.high&&l
tguilbert 2016/09/16 22:48:14 Done.
+ // See crypto::SecureMemEqual()'s comments for more context.
+ return ((high_ ^ other.high_) | (low_ ^ other.low_)) == 0;
+ }
+
+ bool operator!=(const UnguessableToken& other) const {
+ return !(*this == other);
+ }
+
+ private:
+ friend struct UnguessableTokenHash;
+ UnguessableToken(uint64_t high, uint64_t low);
+
+ // Note: Two uint64_t are used instead of uint8_t[16], in order to have a
+ // simpler ToString() and is_empty().
+ uint64_t high_ = 0;
+ uint64_t low_ = 0;
+};
+
+// For use in std::unordered_map.
+struct UnguessableTokenHash {
+ size_t operator()(const base::UnguessableToken& token) const {
+ DCHECK(token);
+ return base::HashInts64(token.high_, token.low_);
+ }
+};
+
+} // namespace base
+
+#endif // BASE_UNGUESSABLE_TOKEN_H_
« no previous file with comments | « base/BUILD.gn ('k') | base/unguessable_token.cc » ('j') | base/unguessable_token.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698