Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 233343002: Fix chromium ranges output in v8 releases script. (Closed)

Created:
6 years, 8 months ago by Michael Achenbach
Modified:
6 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Fix chromium ranges output in v8 releases script. Add space after commas for auto line break in spreadsheets. Add default empty strings to avoid undefined values in spreadsheets. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/push-to-trunk/releases.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 8 months ago (2014-04-10 14:38:45 UTC) #1
Jarin
lgtm
6 years, 8 months ago (2014-04-11 07:26:35 UTC) #2
Michael Achenbach
6 years, 8 months ago (2014-04-11 07:40:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698