Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2333423002: Simulated fonts aren't TrueType fonts. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simulated fonts aren't TrueType fonts. Some font back-ends provide simulated fonts such as fake bold or fake oblique. These fonts should not be reported as TrueType, since the font data isn't what is actually used to draw the glyphs. BUG=chromium:639198 BUG=chromium:614612 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333423002 Committed: https://skia.googlesource.com/skia/+/0b7758236ca81337aa465a9f61cf466f03718862

Patch Set 1 #

Patch Set 2 : Also FontConfig. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M src/ports/SkFontMgr_fontconfig.cpp View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 3 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
bungeman-skia
Try it out, I'll see about updating the FreeType one too.
4 years, 3 months ago (2016-09-13 19:24:24 UTC) #3
bungeman-skia
Now with FontConfig synthetics.
4 years, 3 months ago (2016-09-13 20:02:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333423002/20001
4 years, 3 months ago (2016-09-13 21:01:25 UTC) #13
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-13 21:01:27 UTC) #14
hal.canary
lgtm
4 years, 3 months ago (2016-09-13 21:01:29 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 21:03:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0b7758236ca81337aa465a9f61cf466f03718862

Powered by Google App Engine
This is Rietveld 408576698