[Merge to 54] Add observer for BAAnnots from Javascript

[Merge to 54] Add observer for BAAnnots from Javascript

This Cl moves the observer code from the CPDFSDK_Widget up into the
CPDFSDK_Annot base class and then adds a second observer for CPDFSDK_BAAnnot
objects.

This allows us to attach an observer to the Annot javascript class which will
update its internal pointer to the BAAnnot if the BAAnnot is destroyed by
the CPDFSDK_PageView being destroyed.

BUG=chromium:642307
R=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2306663002
Committed: https://pdfium.googlesource.com/pdfium/+/0703fa810bc79a335ddfdab3e7661159caf88e2d

[dsinclair, 2016-09-13 18:28:34]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-09-13 18:28:35]

PTAL.

https://codereview.chromium.org/2333383002/diff/1/fpdfsdk/include/cpdfsdk_wid...
File fpdfsdk/include/cpdfsdk_widget.h (right):

https://codereview.chromium.org/2333383002/diff/1/fpdfsdk/include/cpdfsdk_wid...
fpdfsdk/include/cpdfsdk_widget.h:67: CFX_ByteString GetSubType() const override;
Merge conflicted here.

https://codereview.chromium.org/2333383002/diff/1/fpdfsdk/javascript/Annot.cpp
File fpdfsdk/javascript/Annot.cpp (right):

https://codereview.chromium.org/2333383002/diff/1/fpdfsdk/javascript/Annot.cp...
fpdfsdk/javascript/Annot.cpp:99: CPDFSDK_BAAnnot* baAnnot = ToBAAnnot(m_pAnnot);
Merge conflicted here.

[Tom Sepez, 2016-09-13 18:40:06]

lgtm

[dsinclair, 2016-09-13 18:52:58]

Description was changed from

==========
[Merge to 54] Add observer for BAAnnots from Javascript

This Cl moves the observer code from the CPDFSDK_Widget up into the
CPDFSDK_Annot base class and then adds a second observer for CPDFSDK_BAAnnot
objects.

This allows us to attach an observer to the Annot javascript class which will
update its internal pointer to the BAAnnot if the BAAnnot is destroyed by
the CPDFSDK_PageView being destroyed.

BUG=chromium:642307

Review-Url: https://codereview.chromium.org/2306663002
==========

to

==========
[Merge to 54] Add observer for BAAnnots from Javascript

This Cl moves the observer code from the CPDFSDK_Widget up into the
CPDFSDK_Annot base class and then adds a second observer for CPDFSDK_BAAnnot
objects.

This allows us to attach an observer to the Annot javascript class which will
update its internal pointer to the BAAnnot if the BAAnnot is destroyed by
the CPDFSDK_PageView being destroyed.

BUG=chromium:642307
R=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2306663002
Committed:
https://pdfium.googlesource.com/pdfium/+/0703fa810bc79a335ddfdab3e7661159caf8...
==========

[dsinclair, 2016-09-13 18:53:01]

Committed patchset #1 (id:1) manually as
0703fa810bc79a335ddfdab3e7661159caf88e2d (presubmit successful).