Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2333373003: Add a command-line option to set the exit code on a formatting change. (Closed)

Created:
4 years, 3 months ago by Bob Nystrom
Modified:
4 years, 3 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a command-line option to set the exit code on a formatting change. Fix #365. R=kevmoo@google.com Committed: https://github.com/dart-lang/dart_style/commit/3f83ada758d369353754b04627023e5a40184035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -23 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M bin/format.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M lib/src/debug.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/formatter_options.dart View 4 chunks +45 lines, -21 lines 0 comments Download
M test/command_line_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 3 months ago (2016-09-14 00:14:05 UTC) #2
kevmoo
lgtm
4 years, 3 months ago (2016-09-14 04:06:14 UTC) #3
Bob Nystrom
4 years, 3 months ago (2016-09-14 23:20:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f83ada758d369353754b04627023e5a40184035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698