Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.cc

Issue 2333333002: [Offline Pages] Fixes PrerenderingLoader bug to clear session_contents_ when PrerenderManager does … (Closed)
Patch Set: reverted inadbvertant whitespace change Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_loader.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.cc b/chrome/browser/android/offline_pages/prerendering_loader.cc
index 2584933c487dc4fe7788b1e07ae5e5eec829e0e0..e3579c5fa1193308e701a6904b059b3813e7865e 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader.cc
@@ -49,8 +49,10 @@ bool PrerenderingLoader::LoadPage(const GURL& url,
gfx::Size renderWindowSize = session_contents_->GetContainerBounds().size();
bool accepted = adapter_->StartPrerender(
browser_context_, url, sessionStorageNamespace, renderWindowSize);
- if (!accepted)
+ if (!accepted) {
+ session_contents_.reset(nullptr);
dewittj 2016/09/13 17:03:17 It is unfortunate that we have to create a web con
dougarnett 2016/09/13 18:15:22 Acknowledged.
return false;
+ }
DCHECK(adapter_->IsActive());
snapshot_controller_.reset(
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698