Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: tests/gclient_utils_test.py

Issue 233333003: Make it possible to refer to github-style URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Added another test for the LateOverride to work correctly with scp-style urls. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/gclient_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_utils_test.py
diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py
index e8e667918ab65aa67867b9088dc1add99802bab2..39a3d772d816a0d3eeda577ba6f70a42cbed2866 100755
--- a/tests/gclient_utils_test.py
+++ b/tests/gclient_utils_test.py
@@ -124,6 +124,13 @@ class SplitUrlRevisionTestCase(GclientUtilBase):
out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))
self.assertEquals(out_rev, rev)
self.assertEquals(out_url, url)
+ url = "git@github.com:dart-lang/spark.git"
+ out_url, out_rev = gclient_utils.SplitUrlRevision(url)
+ self.assertEquals(out_rev, None)
+ self.assertEquals(out_url, url)
+ out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))
+ self.assertEquals(out_rev, rev)
+ self.assertEquals(out_url, url)
def testSVNUrl(self):
url = "svn://example.com/test"
« no previous file with comments | « tests/gclient_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698