gclient.py - Issue 233333003: Make it possible to refer to github-style URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 233333003: Make it possible to refer to github-style URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Added another test for the LateOverride to work correctly with scp-style urls. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index 5c5c5ca5f57f4ae3cb692e8fa2c7f51167fedd43..80a15c37672ddd05cb5fa6a5e8be29036f9050cb 100755

--- a/gclient.py

+++ b/gclient.py

@@ -435,7 +435,8 @@ class Dependency(gclient_utils.WorkItem, DependencySettings):

if isinstance(url, basestring):

parsed_url = urlparse.urlparse(url)

- if not parsed_url[0]:

+ if (not parsed_url[0] and

+ not re.match(r'^\w+\@[\w\.-]+\:[\w\/]+', parsed_url[2])):

# A relative url. Fetch the real base.

path = parsed_url[2]

if not path.startswith('/'):

« no previous file with comments | « no previous file | gclient_utils.py » ('j') | no next file with comments »