Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: gclient.py

Issue 233333003: Make it possible to refer to github-style URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Handle any user for scp-like URLs Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | gclient_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 5c5c5ca5f57f4ae3cb692e8fa2c7f51167fedd43..6769d3ab97208c38ac35b5aaad38370615fe71b9 100755
--- a/gclient.py
+++ b/gclient.py
@@ -435,7 +435,8 @@ class Dependency(gclient_utils.WorkItem, DependencySettings):
if isinstance(url, basestring):
parsed_url = urlparse.urlparse(url)
- if not parsed_url[0]:
+ if not parsed_url[0] and not re.match(r'^\w+\@[\w\.-]+\:[\w\/]+', parsed_url[2]):
bradn 2014/04/11 01:49:41 if (... ...):
Sheridan Rawlins 2014/04/11 04:15:16 Done.
+ print 'match = %s' % re.match(r'^\w+\@\w+\:[\w\/]+', parsed_url[2])
bradn 2014/04/11 01:49:41 drop leftover print
Sheridan Rawlins 2014/04/11 04:15:16 Done.
# A relative url. Fetch the real base.
path = parsed_url[2]
if not path.startswith('/'):
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | gclient_utils.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698