Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: gclient_utils.py

Issue 233333003: Make it possible to refer to github-style URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gclient.py ('K') | « gclient.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index c394862f76645aaef15b9352f68a3585be422998..5fb2f69e05e9e251fb66d80a69298278200ad6f2 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -76,6 +76,10 @@ def SplitUrlRevision(url):
components = re.search(regex, url).groups()
else:
components = url.split('@', 1)
bradn 2014/04/10 22:19:27 Couldn't you just change this to use rsplit instea
Sheridan Rawlins 2014/04/11 01:05:46 Well, the code handles urls that don't lock the DE
+ if url.startswith('git@'):
bradn 2014/04/10 22:19:27 Technically can't these be any username? Though wi
Sheridan Rawlins 2014/04/11 01:05:46 Yes; Done.
+ components = components[1].split('@', 1)
+ components[0] = 'git@' + components[0]
+
if len(components) == 1:
components += [None]
return tuple(components)
« gclient.py ('K') | « gclient.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698