Make it possible to refer to github-style URLs.

gclient_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic utils."""
 
 import codecs
 import cStringIO
 import datetime
 import logging
@@ skipping 57 matching lines @@
   _WARNINGS.append(msg)
 
 
 def SplitUrlRevision(url):
   """Splits url and returns a two-tuple: url, rev"""
   if url.startswith('ssh:'):
     # Make sure ssh://user-name@example.com/~/test.git@stable works
     regex = r'(ssh://(?:[-.\w]+@)?[-\w:\.]+/[-~\w\./]+)(?:@(.+))?'
     components = re.search(regex, url).groups()
   else:
     components = url.split('@', 1)

[bradn, 2014/04/10 22:19:27]

Couldn't you just change this to use rsplit instead?

[Sheridan Rawlins, 2014/04/11 01:05:46]

Well, the code handles urls that don't lock the DEPS to an exact version; how
'bout this instead.

+    if url.startswith('git@'):

[bradn, 2014/04/10 22:19:27]

Technically can't these be any username?
Though with the rsplit change you might not need to check for this explicitly.

[Sheridan Rawlins, 2014/04/11 01:05:46]

Yes; Done.

+      components = components[1].split('@', 1)
+      components[0] = 'git@' + components[0]
+
     if len(components) == 1:
       components += [None]
   return tuple(components)
 
 
 def IsDateRevision(revision):
   """Returns true if the given revision is of the form "{ ... }"."""
   return bool(revision and re.match(r'^\{.+\}$', str(revision)))
 
 
@@ skipping 988 matching lines @@
 def DefaultIndexPackConfig(url=''):
   """Return reasonable default values for configuring git-index-pack.
 
   Experiments suggest that higher values for pack.threads don't improve
   performance."""
   cache_limit = DefaultDeltaBaseCacheLimit()
   result = ['-c', 'core.deltaBaseCacheLimit=%s' % cache_limit]
   if url in THREADED_INDEX_PACK_BLACKLIST:
     result.extend(['-c', 'pack.threads=1'])
   return result