Make it possible to refer to github-style URLs.

gclient.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Meta checkout manager supporting both Subversion and GIT."""
 # Files
 #   .gclient      : Current client configuration, written by 'config' command.
 #                   Format is a Python script defining 'solutions', a list whose
 #                   entries each are maps binding the strings "name" and "url"
@@ skipping 382 matching lines @@
       logging.warn('Won\'t process duplicate dependency %s' % sibling)
       return False
     return True
 
   def LateOverride(self, url):
     """Resolves the parsed url from url.
 
     Manages From() keyword accordingly. Do not touch self.parsed_url nor
     self.url because it may called with other urls due to From()."""
     assert self.parsed_url == None or not self.should_process, self.parsed_url
+    if url.startswith('git@'):

[bradn, 2014/04/10 22:19:27]

Move this down to where url is known to be a string.
Since this could be any username, may check against:
re.match('^[a-z]+[@].*', url) instead?

[Sheridan Rawlins, 2014/04/11 01:05:46]

Ah, too true -
https://www.kernel.org/pub/software/scm/git/docs/git-clone.html#_git_urls_a_i...
describes it as a "scp-like syntax".

On 2014/04/10 22:19:27, bradn wrote:

+      return url
     parsed_url = self.get_custom_deps(self.name, url)
     if parsed_url != url:
       logging.info(
           'Dependency(%s).LateOverride(%s) -> %s' %
           (self.name, url, parsed_url))
       return parsed_url
 
     if isinstance(url, self.FromImpl):
       # Requires tree traversal.
       ref = [
@@ skipping 14 matching lines @@
 
       # Call LateOverride() again.
       found_dep = found_deps[0]
       parsed_url = found_dep.LateOverride(found_dep.url)
       logging.info(
           'Dependency(%s).LateOverride(%s) -> %s (From)' %
           (self.name, url, parsed_url))
       return parsed_url
 
     if isinstance(url, basestring):
       parsed_url = urlparse.urlparse(url)

[bradn, 2014/04/10 22:19:27]

in here.

[Sheridan Rawlins, 2014/04/11 01:05:46]

Done.

       if not parsed_url[0]:
         # A relative url. Fetch the real base.
         path = parsed_url[2]
         if not path.startswith('/'):
           raise gclient_utils.Error(
               'relative DEPS entry \'%s\' must begin with a slash' % url)
         # Create a scm just to query the full url.
         parent_url = self.parent.parsed_url
         if isinstance(parent_url, self.FileImpl):
           parent_url = parent_url.file_location
@@ skipping 1518 matching lines @@
     print >> sys.stderr, 'Error: %s' % str(e)
     return 1
   finally:
     gclient_utils.PrintWarnings()
 
 
 if '__main__' == __name__:
   sys.exit(Main(sys.argv[1:]))
 
 # vim: ts=2:sw=2:tw=80:et: