Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1962)

Unified Diff: remoting/host/it2me/BUILD.gn

Issue 2333313003: Fixing a crash when showing GTK dialogs on Linux on Debug builds. (Closed)
Patch Set: Moving GTK hack into a desktop_linux condition Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/it2me/BUILD.gn
diff --git a/remoting/host/it2me/BUILD.gn b/remoting/host/it2me/BUILD.gn
index a7771cf2901334740eba868b0c300466d43292b5..a9b530da5f21c150a9d91cefeaac571e7cbb1d95 100644
--- a/remoting/host/it2me/BUILD.gn
+++ b/remoting/host/it2me/BUILD.gn
@@ -57,6 +57,15 @@ source_set("common") {
"//remoting/protocol",
"//remoting/resources",
]
+
+ if (is_desktop_linux) {
+ # GTK2 pulls pangoft2 as dependency, and pangoft2 depends on harfbuzz.
+ # To avoid missing indirectly referenced harfbuzz symbols from pango,
+ # some hack is required when bundled harfbuzz is used and component build is
+ # disabled.
+ # See crbug.com/462689 for details.
+ all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ]
+ }
}
if (!is_chromeos && !is_android && enable_remoting_host) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698