Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2333313003: Fixing a crash when showing GTK dialogs on Linux on Debug builds. (Closed)

Created:
4 years, 3 months ago by joedow
Modified:
4 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing a crash when showing GTK dialogs on Linux on Debug builds. This problem was introduced several months ago (crbug.com/462689) and causes a crash when a GTK dialog is displayed on debug, non-component builds on Linux. The fix is to include some additional linker flags in this scenario (see libgtk2ui target as another example of this workaround) which allows the framework to run correctly. BUG=613231 Committed: https://crrev.com/2f9cb1d89dd0c905bfb7f666126fb41a149f938a Cr-Commit-Position: refs/heads/master@{#418427}

Patch Set 1 #

Patch Set 2 : Moving GTK hack into a desktop_linux condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M remoting/host/it2me/BUILD.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
joedow
PTAL!
4 years, 3 months ago (2016-09-13 23:10:33 UTC) #6
Sergey Ulanov
lgtm
4 years, 3 months ago (2016-09-13 23:59:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333313003/20001
4 years, 3 months ago (2016-09-14 00:03:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 00:09:46 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 00:11:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f9cb1d89dd0c905bfb7f666126fb41a149f938a
Cr-Commit-Position: refs/heads/master@{#418427}

Powered by Google App Engine
This is Rietveld 408576698