Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2333293002: [heap] Remove old_gen_exhausted_ state. (Closed)

Created:
4 years, 3 months ago by Hannes Payer (out of office)
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove old_gen_exhausted_ state. The AllocationResult already carries the information in which space the allocation failure happened. BUG= Committed: https://crrev.com/526f4dc6769b2ad89e09868b99be0c51848b5b34 Cr-Commit-Position: refs/heads/master@{#39387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Hannes Payer (out of office)
4 years, 3 months ago (2016-09-13 13:50:04 UTC) #5
ulan
lgtm
4 years, 3 months ago (2016-09-13 13:52:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333293002/1
4 years, 3 months ago (2016-09-13 13:56:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 14:17:31 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 14:18:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/526f4dc6769b2ad89e09868b99be0c51848b5b34
Cr-Commit-Position: refs/heads/master@{#39387}

Powered by Google App Engine
This is Rietveld 408576698