Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2333283004: [CUPS] Implement the UI handler for adding a new printer. (Closed)
Patch Set: Address michaelpg@'s offline comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
index edba3e811cc6b9b45b504fb73914509e71a63d91..6be2a3e0244cb92926062738208dedbef2cef349 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
@@ -184,9 +184,8 @@
<paper-button class="cancel-button" on-tap="onCancelTap_">
$i18n{cancelButtonText}
</paper-button>
- <paper-button class="action-button" on-tap="switchToManufacturerDialog_"
- disabled="[[addPrinterNotAllowed_(newPrinter.printerName,
- newPrinter.printerAddress)]]">
+ <paper-button class="action-button" on-tap="switchToConfiguringDialog_"
+ disabled="[[!newPrinter.printerName]]">
$i18n{addPrinterButtonText}
</paper-button>
</div>
@@ -225,6 +224,13 @@
width: 340px;
}
+ .error-message {
+ background-color: var(--google-red-100);
+ color: red;
+ margin-top: 10px;
+ padding: 10px 20px;
+ }
+
#manuallyAddPrinterButton {
-webkit-margin-end: 210px;
}
@@ -271,6 +277,9 @@
</div>
</div>
</div>
+ <div class="error-message" hidden="[[!setupFailed]]">
+ Driver not found (exact error message TBD)
+ </div>
</div>
<div class="dialog-buttons">
<paper-button id="manuallyAddPrinterButton"
@@ -336,7 +345,8 @@
<!-- Manufacturer and Model Dialog -->
<template is="dom-if" if="[[showManufacturerDialog_]]" restamp>
- <add-printer-manufacturer-model-dialog new-printer="{{newPrinter}}">
+ <add-printer-manufacturer-model-dialog new-printer="{{newPrinter}}"
+ setup-failed="[[setupFailed]]">
</add-printer-manufacturer-model-dialog>
</template>

Powered by Google App Engine
This is Rietveld 408576698