Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2921)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

Issue 2333283004: [CUPS] Implement the UI handler for adding a new printer. (Closed)
Patch Set: Rebase. Nits fix. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
index d53eb12854981bcf1e8ffe7e89717e1fa2181891..c551db0d9b5b8f533de0129b16a7630e9cbd6f13 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
+++ b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
@@ -49,8 +49,12 @@ cr.define('settings', function() {
/**
* @param {string} printerId
michaelpg 2016/09/20 20:58:42 add param
xdai1 2016/09/21 17:40:19 Done.
*/
- removeCupsPrinter: function(printerId) {},
+ removeCupsPrinter: function(printerId, printerName) {},
+ /**
+ * @param {!CupsPrinterInfo} newPrinter
+ */
+ addCupsPrinter: function(newPrinter) {},
};
/**
@@ -61,19 +65,24 @@ cr.define('settings', function() {
cr.addSingletonGetter(CupsPrintersBrowserProxyImpl);
CupsPrintersBrowserProxyImpl.prototype = {
- /** override */
+ /** @override */
getCupsPrintersList: function() {
return cr.sendWithPromise('getCupsPrintersList');
},
- /** override */
+ /** @override */
updateCupsPrinter: function(printerId, printerName) {
chrome.send('updateCupsPrinter', [printerId, printerName]);
},
- /** override */
- removeCupsPrinter: function(printerId) {
- chrome.send('removeCupsPrinter', [printerId]);
+ /** @override */
+ removeCupsPrinter: function(printerId, printerName) {
+ chrome.send('removeCupsPrinter', [printerId, printerName]);
+ },
+
+ /** @override */
+ addCupsPrinter: function(newPrinter) {
+ chrome.send('addCupsPrinter', [newPrinter]);
},
};

Powered by Google App Engine
This is Rietveld 408576698