Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2333243004: CallConstruct also gets call count information if megamorphic. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CallConstruct also gets call count information if megamorphic. BUG= Committed: https://crrev.com/3ccedd5d8a24281b4abc0af4bfe41d4212a794e6 Cr-Commit-Position: refs/heads/master@{#39398}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : Compile/runtime fixes. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -154 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 4 chunks +5 lines, -16 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 4 chunks +5 lines, -17 lines 0 comments Download
M src/ast/ast.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +4 lines, -5 lines 2 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +5 lines, -15 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 6 chunks +11 lines, -37 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 4 chunks +5 lines, -15 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 4 chunks +5 lines, -17 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 6 chunks +6 lines, -19 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
mvstanton
HI Mythri, hi Benedikt, Here is step 2, where CallConstruct now has counts for megamorphic ...
4 years, 3 months ago (2016-09-13 13:52:24 UTC) #2
Benedikt Meurer
I love it. LGTM :-) https://codereview.chromium.org/2333243004/diff/40001/src/compiler/js-call-reducer.cc File src/compiler/js-call-reducer.cc (right): https://codereview.chromium.org/2333243004/diff/40001/src/compiler/js-call-reducer.cc#newcode389 src/compiler/js-call-reducer.cc:389: CallICNexus nexus(p.feedback().vector(), p.feedback().slot()); Nice! ...
4 years, 3 months ago (2016-09-13 17:11:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333243004/40001
4 years, 3 months ago (2016-09-14 03:20:20 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-14 03:23:03 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 03:23:58 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ccedd5d8a24281b4abc0af4bfe41d4212a794e6
Cr-Commit-Position: refs/heads/master@{#39398}

Powered by Google App Engine
This is Rietveld 408576698