Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2333233002: Add WebGLImageConversionTest (Closed)

Created:
4 years, 3 months ago by Prashant.Patil
Modified:
4 years, 3 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis, manojkumar.bhosale, parag.salasakar_imgtec.com, kaustubh.raste_imgtec.com, raghu.gandham_imgtec.com, gordana.cmiljanovic_imgtec.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebGLImageConversionTest We add WebGLImageConversionTest in blink_platform_unittests. This covers following conversion tests: - ConvertRGBA4444toRGBA8 - ConvertRGBA5551toRGBA8 - ConvertRGBA8toRA8 - convertBGRA8toRGBA8 - ConvertRGBA8toR8 - ConvertRGBA8toRGBA8 - ConvertRGBA8ToUnsignedShort4444 - ConvertRGBA8ToRGBA5551 - ConvertRGBA8ToRGB565 R=kbr@chromium.org BUG=642653 Committed: https://crrev.com/0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b Cr-Commit-Position: refs/heads/master@{#418486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversionTest.cpp View 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Prashant.Patil
4 years, 3 months ago (2016-09-13 10:31:32 UTC) #1
Prashant.Patil
4 years, 3 months ago (2016-09-13 10:36:49 UTC) #4
Ken Russell (switch to Gerrit)
Nice work. LGTM given that this passed the CQ dry run.
4 years, 3 months ago (2016-09-14 00:09:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333233002/1
4 years, 3 months ago (2016-09-14 04:29:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 04:33:45 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 04:35:38 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b
Cr-Commit-Position: refs/heads/master@{#418486}

Powered by Google App Engine
This is Rietveld 408576698