Move RenderLayerCompositor trigger caching to be when settings change

Source/core/rendering/compositing/RenderLayerCompositor.cpp

Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
index daa0cdfb5dd2afebe9fbed3eddf9334432e7cf17..013031e5c8cb68759d34f567101b79e275c4b8b3 100644
--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
@@ -118,6 +118,7 @@ RenderLayerCompositor::RenderLayerCompositor(RenderView& renderView)
     , m_isTrackingRepaints(false)
     , m_rootLayerAttachment(RootLayerUnattached)
 {
+    updateAcceleratedCompositingSettings();
 }
 
 RenderLayerCompositor::~RenderLayerCompositor()
@@ -140,12 +141,26 @@ void RenderLayerCompositor::enableCompositingMode(bool enable)
     notifyIFramesOfCompositingChange();
 }
 
-void RenderLayerCompositor::cacheAcceleratedCompositingFlags()
+void RenderLayerCompositor::updateForceCompositingMode()
+{
+    // FIXME: Can settings really be null here?

[esprehn, 2014/04/11 02:49:19]

I don't think so, if you have a RenderView you should have a Settings.

[ojan, 2014/04/11 03:08:48]

Yup. That's what I was thinking, but I wanted to fix that in a followup patch.
This patch is already doing enough.

+    if (Settings* settings = m_renderView.document().settings()) {
+        bool forceCompositingMode = settings->forceCompositingMode() && m_hasAcceleratedCompositing;
+        if (forceCompositingMode && !isMainFrame())
+            forceCompositingMode = m_compositingReasonFinder.requiresCompositingForScrollableFrame();
+        if (forceCompositingMode != m_forceCompositingMode) {
+            setCompositingLayersNeedRebuild();
+            m_forceCompositingMode = forceCompositingMode;
+        }
+    }
+}
+
+void RenderLayerCompositor::updateAcceleratedCompositingSettings()
 {
     bool hasAcceleratedCompositing = false;
     bool showRepaintCounter = false;
-    bool forceCompositingMode = false;
 
+    // FIXME: Can settings really be null here?
     if (Settings* settings = m_renderView.document().settings()) {
         hasAcceleratedCompositing = settings->acceleratedCompositingEnabled();
 
@@ -159,18 +174,15 @@ void RenderLayerCompositor::cacheAcceleratedCompositingFlags()
         }
 
         showRepaintCounter = settings->showRepaintCounter();
-        forceCompositingMode = settings->forceCompositingMode() && hasAcceleratedCompositing;
-
-        if (forceCompositingMode && !isMainFrame())
-            forceCompositingMode = m_compositingReasonFinder.requiresCompositingForScrollableFrame();
     }
 
-    if (hasAcceleratedCompositing != m_hasAcceleratedCompositing || showRepaintCounter != m_showRepaintCounter || forceCompositingMode != m_forceCompositingMode)
+    if (hasAcceleratedCompositing != m_hasAcceleratedCompositing || showRepaintCounter != m_showRepaintCounter)
         setCompositingLayersNeedRebuild();
 
     m_hasAcceleratedCompositing = hasAcceleratedCompositing;
     m_showRepaintCounter = showRepaintCounter;
-    m_forceCompositingMode = forceCompositingMode;
+
+    updateForceCompositingMode();
 }
 
 bool RenderLayerCompositor::layerSquashingEnabled() const