Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2333213005: Remove inner FX_DATETIME struct from CPDFSDK_DateTime (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove inner FX_DATETIME struct from CPDFSDK_DateTime There's a separate, different FX_DATETIME in XFA. Once we remove memcpy(), there's no reason to have the inner struct for sizing. Committed: https://pdfium.googlesource.com/pdfium/+/b31ca718ee94b681b9a1c3e59dcd885a4f421a5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -68 lines) Patch
M fpdfsdk/cpdfsdk_datetime.cpp View 18 chunks +64 lines, -57 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_datetime.h View 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, for review
4 years, 3 months ago (2016-09-13 22:26:10 UTC) #2
dsinclair
lgtm
4 years, 3 months ago (2016-09-14 01:08:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333213005/1
4 years, 3 months ago (2016-09-14 01:08:19 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 01:10:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b31ca718ee94b681b9a1c3e59dcd885a4f42...

Powered by Google App Engine
This is Rietveld 408576698