Add a private API method to install a webstore app from Files.app

chrome/browser/chromeos/extensions/file_manager/file_manager_installer.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[hashimoto, 2013/08/30 09:09:37]

nit: Current style does not have "(c)" in a file header.
http://www.chromium.org/developers/coding-style#TOC-File-headers

[yoshiki, 2013/08/30 09:51:46]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_FILE_MANAGER_INSTALLER_H_
+#define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_FILE_MANAGER_INSTALLER_H_
+
+#include <string>
+
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/extensions/webstore_standalone_installer.h"
+#include "content/public/browser/web_contents_observer.h"
+
+namespace content {
+class WebContents;
+}
+
+namespace file_manager {
+
+// Installer for Files.app.
+class FileManagerInstaller
+    : public extensions::WebstoreStandaloneInstaller,
+      public content::WebContentsObserver {

[hashimoto, 2013/08/30 09:09:37]

Our style guide does not allow inheriting multiple non-pure-interface classses.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Multiple_Inher...

You should do: splitting this class into two parts, modifying this class to own
sub-classes of WebstoreStandaloneInstaller and WebContentsObserver or something
like that.

[yoshiki, 2013/08/30 09:51:46]

I didn't know it. Thanks. Done.

+ public:
+  typedef extensions::WebstoreStandaloneInstaller::Callback Callback;
+
+  FileManagerInstaller(content::WebContents* web_contents,
+                       const std::string& webstore_item_id,
+                       Profile* profile,
+                       const Callback& callback);
+
+ protected:
+  friend class base::RefCountedThreadSafe<FileManagerInstaller>;
+
+  virtual ~FileManagerInstaller();
+
+  // WebstoreStandaloneInstaller implementation.
+  virtual bool CheckRequestorAlive() const OVERRIDE;
+  virtual const GURL& GetRequestorURL() const OVERRIDE;
+  virtual bool ShouldShowPostInstallUI() const OVERRIDE;
+  virtual bool ShouldShowAppInstalledBubble() const OVERRIDE;
+  virtual content::WebContents* GetWebContents() const OVERRIDE;
+  virtual scoped_ptr<ExtensionInstallPrompt::Prompt>
+      CreateInstallPrompt() const OVERRIDE;
+  virtual bool CheckInlineInstallPermitted(
+      const base::DictionaryValue& webstore_data,
+      std::string* error) const OVERRIDE;
+  virtual bool CheckRequestorPermitted(
+      const base::DictionaryValue& webstore_data,
+      std::string* error) const OVERRIDE;
+
+ private:
+  // content::WebContentsObserver implementation.

[hashimoto, 2013/08/30 09:09:37]

Why this part is private while WebstoreStandaloneInstaller methods are
protected?
I think this should be protected too.

[yoshiki, 2013/08/30 09:51:46]

Done.

+  virtual void WebContentsDestroyed(
+      content::WebContents* web_contents) OVERRIDE;
+
+  // Dummy GURL object to return from GetRequestorURL() method.
+  GURL dummy_url_;

[hashimoto, 2013/08/30 09:09:37]

How about using GURL::EmptyGURL instead of having this member?

[yoshiki, 2013/08/30 09:51:46]

Done.

+  Callback callback_;
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(FileManagerInstaller);
+};
+
+}  // namespace file_manager
+
+#endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_FILE_MANAGER_INSTALLER_H_