Add a private API method to install a webstore app from Files.app

chrome/browser/chromeos/extensions/file_manager/webstore_app_installer.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_WEBSTORE_APP_INSTALLER_H_
+#define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_WEBSTORE_APP_INSTALLER_H_
+
+#include <string>
+
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/extensions/webstore_standalone_installer.h"
+#include "content/public/browser/web_contents_observer.h"
+
+namespace content {
+class WebContents;
+}
+
+namespace file_manager {
+
+// Installer for Files.app.
+class WebstoreAppInstaller

[asargent_no_longer_on_chrome, 2013/08/27 18:22:33]

This class name is confusingly similar  to WebstoreInstaller - can we pick
something else? Maybe FileManagerInstaller? 

[yoshiki, 2013/08/28 13:19:04]

Done.

+    : public extensions::WebstoreStandaloneInstaller,
+      public content::WebContentsObserver {
+ public:
+  typedef extensions::WebstoreStandaloneInstaller::Callback Callback;
+
+  WebstoreAppInstaller(content::WebContents* web_contents,
+                          const std::string& webstore_item_id,
+                          Profile* profile,
+                          const Callback& callback);

[asargent_no_longer_on_chrome, 2013/08/27 18:22:33]

nit: indentation is off on these 3 lines

[yoshiki, 2013/08/28 13:19:04]

Done.

+
+ protected:
+  friend class base::RefCountedThreadSafe<WebstoreAppInstaller>;
+
+  virtual ~WebstoreAppInstaller();
+
+  // Implementations WebstoreStandaloneInstaller Template Method's hooks.

[asargent_no_longer_on_chrome, 2013/08/27 18:22:33]

nit: to be pedantic, it's not a template (in the C++ sense), it's an abstract
base class with pure virtual methods. We often just refer to this as an
interface ; eg 

"Implements the WebstoreStandaloneInstaller interface."


I think the "Template Method" comment in webstore_standalone_installer.h is
referring to the "Template Method Design Pattern", but I may go remove or
clarify that comment because I think it's confusing since it has nothing to do
with C++ templates. 

[yoshiki, 2013/08/28 13:19:04]

Thanks, I grep'd and have found "// SomeClassName implementation." seems to be
more common. I use this instead.

+  virtual bool CheckRequestorAlive() const OVERRIDE;
+  virtual const GURL& GetRequestorURL() const OVERRIDE;
+  virtual bool ShouldShowPostInstallUI() const OVERRIDE;
+  virtual bool ShouldShowAppInstalledBubble() const OVERRIDE;
+  virtual content::WebContents* GetWebContents() const OVERRIDE;
+  virtual scoped_ptr<ExtensionInstallPrompt::Prompt>
+      CreateInstallPrompt() const OVERRIDE;
+  virtual bool CheckInlineInstallPermitted(
+      const base::DictionaryValue& webstore_data,
+      std::string* error) const OVERRIDE;
+  virtual bool CheckRequestorPermitted(
+      const base::DictionaryValue& webstore_data,
+      std::string* error) const OVERRIDE;
+
+ private:
+  // content::WebContentsObserver interface implementation.
+  virtual void WebContentsDestroyed(
+      content::WebContents* web_contents) OVERRIDE;
+
+  GURL dummy_url_;

[asargent_no_longer_on_chrome, 2013/08/27 18:22:33]

nit: this variable could use a comment since it isn't immediately obvious what
it's for

[yoshiki, 2013/08/28 13:19:04]

Done.

+  Callback callback_;
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(WebstoreAppInstaller);
+};
+
+}  // namespace file_manager
+
+#endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_WEBSTORE_APP_INSTALLER_H_