Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2333193002: Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/5e92033a06bb447ff5a6f8d367fb26680f49e325 Cr-Commit-Position: refs/heads/master@{#418777}

Patch Set 1 : 2016-09-13T17:28:55 #

Patch Set 2 : 2016-09-13T18:54:36 #

Patch Set 3 : 2016-09-15T11:30:17 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/editing/deleting/delete-to-end-of-paragraph.html View 1 1 chunk +40 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-to-end-of-paragraph-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-13 09:25:35 UTC) #5
Xiaocheng
Is there anyway to prevent using eventSender to set focus? That seems to be hacking ...
4 years, 3 months ago (2016-09-13 09:36:56 UTC) #6
yosin_UTC9
On 2016/09/13 at 09:36:56, xiaochengh wrote: > Is there anyway to prevent using eventSender to ...
4 years, 3 months ago (2016-09-13 09:56:32 UTC) #12
Xiaocheng
On 2016/09/13 at 09:56:32, yosin wrote: > On 2016/09/13 at 09:36:56, xiaochengh wrote: > > ...
4 years, 3 months ago (2016-09-13 11:17:35 UTC) #15
yosin_UTC9
PTAL This patch doesn't have assert_selection.js changes anymore. assert_selection() moves focus to sample IFRAME.
4 years, 3 months ago (2016-09-15 03:46:46 UTC) #21
Xiaocheng
lgtm
4 years, 3 months ago (2016-09-15 03:49:41 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333193002/40001
4 years, 3 months ago (2016-09-15 04:18:26 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 04:23:13 UTC) #25
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 04:25:17 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e92033a06bb447ff5a6f8d367fb26680f49e325
Cr-Commit-Position: refs/heads/master@{#418777}

Powered by Google App Engine
This is Rietveld 408576698