|
|
Created:
4 years, 3 months ago by yosin_UTC9 Modified:
4 years, 3 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness
This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use
w3c test harness to simplify test script for improving
code health.
BUG=n/a
TEST=n/a; no behavior changes
Committed: https://crrev.com/5e92033a06bb447ff5a6f8d367fb26680f49e325
Cr-Commit-Position: refs/heads/master@{#418777}
Patch Set 1 : 2016-09-13T17:28:55 #Patch Set 2 : 2016-09-13T18:54:36 #Patch Set 3 : 2016-09-15T11:30:17 #
Messages
Total messages: 27 (18 generated)
Description was changed from ========== 2016-09-13T17:28:55 BUG= ========== to ========== Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
Is there anyway to prevent using eventSender to set focus? That seems to be hacking into the implementation details of assert_selection.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes ========== to ========== Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. This patch also updates |assert_selection()| to move focus to IFRAME containing test sample to run commands invoked by |testRunner.execCommand()|. BUG=n/a TEST=n/a; no behavior changes ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/13 at 09:36:56, xiaochengh wrote: > Is there anyway to prevent using eventSender to set focus? > > That seems to be hacking into the implementation details of assert_selection. PTAL Make sense. Integrate moving focus into |assert_selection()|.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2016/09/13 at 09:56:32, yosin wrote: > On 2016/09/13 at 09:36:56, xiaochengh wrote: > > Is there anyway to prevent using eventSender to set focus? > > > > That seems to be hacking into the implementation details of assert_selection. > > PTAL > > Make sense. Integrate moving focus into |assert_selection()|. Oops, there are bugs.
Description was changed from ========== Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. This patch also updates |assert_selection()| to move focus to IFRAME containing test sample to run commands invoked by |testRunner.execCommand()|. BUG=n/a TEST=n/a; no behavior changes ========== to ========== Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL This patch doesn't have assert_selection.js changes anymore. assert_selection() moves focus to sample IFRAME.
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes ========== to ========== Convert editing/deleting/delete-to-end-of-paragraph.html to use w3c test harness This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/5e92033a06bb447ff5a6f8d367fb26680f49e325 Cr-Commit-Position: refs/heads/master@{#418777} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5e92033a06bb447ff5a6f8d367fb26680f49e325 Cr-Commit-Position: refs/heads/master@{#418777} |