Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2333183002: bluetooth: setShouldCloseOnResignKey so that the chooser closes when it loses focus (Closed)

Created:
4 years, 3 months ago by ortuno
Modified:
4 years, 3 months ago
Reviewers:
Robert Sesek, juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: setShouldCloseOnResignKey so that the chooser closes when it loses focus Before users could click a button multiple times and it would open multiple choosers. With this change the chooser will loose focus as soon as the user clicks outside the chooser. BUG=635905 Committed: https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a Cr-Commit-Position: refs/heads/master@{#418380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
ortuno
juncai: PTAL :)
4 years, 3 months ago (2016-09-13 08:02:22 UTC) #2
juncai
Nice! LGTM. Thanks!
4 years, 3 months ago (2016-09-13 17:25:07 UTC) #7
ortuno
rsesek: PTAL
4 years, 3 months ago (2016-09-13 21:39:15 UTC) #9
Robert Sesek
LGTM but please fix the small case typo in the CL description (CLose -> Close).
4 years, 3 months ago (2016-09-13 21:40:07 UTC) #10
ortuno
Done. Thanks!
4 years, 3 months ago (2016-09-13 21:41:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333183002/1
4 years, 3 months ago (2016-09-13 21:41:53 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 21:47:33 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 21:50:38 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a
Cr-Commit-Position: refs/heads/master@{#418380}

Powered by Google App Engine
This is Rietveld 408576698