Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2333163002: MD History: Remove isFirstItem property from history-item (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove isFirstItem property from history-item This property can be replaced with padding at the top of <history-list>, which simplifies the code and should have a minor performance improvement. BUG=425625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ebfac84ae4915a943f307fed2871ad7fb41c9920 Cr-Commit-Position: refs/heads/master@{#419101}

Patch Set 1 #

Patch Set 2 : Fix sizing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -29 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tsergeant
4 years, 3 months ago (2016-09-13 07:48:39 UTC) #3
calamity
lgtm
4 years, 3 months ago (2016-09-16 01:49:04 UTC) #8
tsergeant
Whoops, I had messed up the sizing of the <history-list> so the scrollbar went off ...
4 years, 3 months ago (2016-09-16 03:40:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333163002/20001
4 years, 3 months ago (2016-09-16 03:40:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 04:29:09 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 04:32:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebfac84ae4915a943f307fed2871ad7fb41c9920
Cr-Commit-Position: refs/heads/master@{#419101}

Powered by Google App Engine
This is Rietveld 408576698