Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2333153002: Increase coverage for img element's crossOrigin attribute's behavior on redirect (Closed)

Created:
4 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 2 months ago
Reviewers:
hiroshige, yhirano
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase coverage for img element's crossOrigin attribute's behavior on redirect Even after http://crbug.com/563328 was fixed, the behavior is not fully conforming to the spec. Newly added tests will clarify the issue and ensure it's working for the other cases. R=yhirano@chromium.org BUG=646277 Committed: https://crrev.com/131650a98e8d7dc8019b74c6221c8ac3db951c64 Cr-Commit-Position: refs/heads/master@{#425941}

Patch Set 1 #

Patch Set 2 : a #

Patch Set 3 : a #

Patch Set 4 : a #

Patch Set 5 : a #

Patch Set 6 : a #

Patch Set 7 : a #

Patch Set 8 : a #

Patch Set 9 : Rebase #

Total comments: 4

Patch Set 10 : Addressed #17 #

Patch Set 11 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -97 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html View 1 2 3 4 5 6 7 8 9 1 chunk +149 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials-expected.txt View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/img-redirect-to-crossorigin-credentials.html View 1 2 3 4 5 6 7 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
tyoshino (SeeGerritForStatus)
4 years, 3 months ago (2016-09-13 08:27:02 UTC) #4
tyoshino (SeeGerritForStatus)
Hi hiroshige, Could you please review this? If you don't have bandwidth for this or ...
4 years, 2 months ago (2016-10-05 11:20:21 UTC) #11
tyoshino (SeeGerritForStatus)
Hi Yutaka, could you please review this?
4 years, 2 months ago (2016-10-14 04:28:14 UTC) #16
yhirano
https://codereview.chromium.org/2333153002/diff/160001/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html File third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html (right): https://codereview.chromium.org/2333153002/diff/160001/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html#newcode144 third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html:144: </script> To be removed? https://codereview.chromium.org/2333153002/diff/160001/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html#newcode153 third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html:153: </script> ditto
4 years, 2 months ago (2016-10-14 09:11:10 UTC) #17
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/2333153002/diff/160001/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html File third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html (right): https://codereview.chromium.org/2333153002/diff/160001/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html#newcode144 third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-credentials.html:144: </script> On 2016/10/14 09:11:09, yhirano wrote: > To be ...
4 years, 2 months ago (2016-10-14 12:09:35 UTC) #19
yhirano
lgtm
4 years, 2 months ago (2016-10-17 12:44:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333153002/200001
4 years, 2 months ago (2016-10-18 10:26:58 UTC) #23
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 2 months ago (2016-10-18 11:24:16 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 11:27:18 UTC) #27
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/131650a98e8d7dc8019b74c6221c8ac3db951c64
Cr-Commit-Position: refs/heads/master@{#425941}

Powered by Google App Engine
This is Rietveld 408576698