Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.h

Issue 2333133003: Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_surface_impl.h
diff --git a/content/browser/renderer_host/offscreen_canvas_surface_impl.h b/content/browser/renderer_host/offscreen_canvas_surface_impl.h
index cf85fe5aec7f25ef1c25fa54007688df47fc2643..7a80d6bbdb65162e1f3a13aae5ffd20f7e4fdabb 100644
--- a/content/browser/renderer_host/offscreen_canvas_surface_impl.h
+++ b/content/browser/renderer_host/offscreen_canvas_surface_impl.h
@@ -5,8 +5,6 @@
#ifndef CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_
#define CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_
-#include "cc/surfaces/surface_factory.h"
-#include "cc/surfaces/surface_factory_client.h"
#include "cc/surfaces/surface_id.h"
#include "cc/surfaces/surface_id_allocator.h"
#include "mojo/public/cpp/bindings/interface_request.h"
@@ -16,25 +14,17 @@
namespace content {
-class OffscreenCanvasSurfaceImpl : public blink::mojom::OffscreenCanvasSurface,
- public cc::SurfaceFactoryClient {
+class OffscreenCanvasSurfaceImpl : public blink::mojom::OffscreenCanvasSurface {
public:
static void Create(
mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request);
// blink::mojom::OffscreenCanvasSurface implementation.
void GetSurfaceId(const GetSurfaceIdCallback& callback) override;
- void RequestSurfaceCreation(const cc::SurfaceId& surface_id) override;
void Require(const cc::SurfaceId& surface_id,
const cc::SurfaceSequence& sequence) override;
void Satisfy(const cc::SurfaceSequence& sequence) override;
- // cc::SurfaceFactoryClient implementation.
- void ReturnResources(const cc::ReturnedResourceArray& resources) override;
- void WillDrawSurface(const cc::SurfaceId& id,
- const gfx::Rect& damage_rect) override;
- void SetBeginFrameSource(cc::BeginFrameSource* begin_frame_source) override;
-
private:
~OffscreenCanvasSurfaceImpl() override;
explicit OffscreenCanvasSurfaceImpl(
@@ -43,7 +33,6 @@ class OffscreenCanvasSurfaceImpl : public blink::mojom::OffscreenCanvasSurface,
// Surface-related state
std::unique_ptr<cc::SurfaceIdAllocator> id_allocator_;
cc::SurfaceId surface_id_;
- std::unique_ptr<cc::SurfaceFactory> surface_factory_;
mojo::StrongBinding<blink::mojom::OffscreenCanvasSurface> binding_;

Powered by Google App Engine
This is Rietveld 408576698