Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient implementation
 from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is lazily created (only happened on the first commit()).

BUG=563852
Committed: https://crrev.com/a3987c8b93d3abbba6ea4e438493bf996fff66b7
Cr-Commit-Position: refs/heads/master@{#418402}

[xlai (Olivia), 2016-09-13 15:37:55]

Description was changed from

==========
Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient
implementation
 from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted.

BUG=563852
==========

to

==========
Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient
implementation
 from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is lazily created (only happened on the first commit()).

BUG=563852
==========

[xlai (Olivia), 2016-09-13 15:37:55]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xlai (Olivia), 2016-09-13 15:40:03]

xlai@chromium.org changed reviewers:
+ dcheng@chromium.org

[xlai (Olivia), 2016-09-13 15:40:04]

junov@: This CL is to facilitate Xida's CL on WebGL commit()
(https://codereview.chromium.org/2328463004/).

dcheng@: I've removed one IPC from offscreen_canvas_surface.mojom.

https://codereview.chromium.org/2333133003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridgeTest.cpp
(right):

https://codereview.chromium.org/2333133003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridgeTest.cpp:5:
#include "platform/graphics/CanvasSurfaceLayerBridge.h"
This unit test becomes pretty boring after the deletion of
requestSurfaceCreation. Shall I just remove this unit test, given that we are
going to have end-to-end tests?

[Justin Novosad, 2016-09-13 17:19:24]

lgtm for third_party/WebKit/Source/platform/*

[dcheng, 2016-09-13 17:23:05]

mojom lgtm

[xlai (Olivia), 2016-09-13 17:27:04]

xlai@chromium.org changed reviewers:
+ fsamuel@chromium.org

[xlai (Olivia), 2016-09-13 17:27:04]

+Fady: could you take a look at content/browser? I'm making
OffscreenCanvasFrameReceiverImpl to be a SurfaceFactoryClient (previously it was
OffscreenCanvasSurfaceImpl) that holds a unique pointer to SurfaceFactory.

[Fady Samuel, 2016-09-13 17:39:42]

Seems reasonable to me. Non-owner LGTM

[xlai (Olivia), 2016-09-13 18:58:34]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:58:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:03:16]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xlai (Olivia), 2016-09-13 19:40:24]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 19:40:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2016-09-13 21:15:07]

The CQ bit was unchecked by xlai@chromium.org

[xlai (Olivia), 2016-09-13 21:15:12]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-09-13 21:15:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, junov@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2333133003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-13 21:15:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 23:10:10]

Description was changed from

==========
Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient
implementation
 from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is lazily created (only happened on the first commit()).

BUG=563852
==========

to

==========
Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient
implementation
 from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is lazily created (only happened on the first commit()).

BUG=563852
==========

[commit-bot: I haz the power, 2016-09-13 23:10:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 23:12:38]

Description was changed from

==========
Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient
implementation
 from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is lazily created (only happened on the first commit()).

BUG=563852
==========

to

==========
Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl

This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient
implementation
 from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is lazily created (only happened on the first commit()).

BUG=563852

Committed: https://crrev.com/a3987c8b93d3abbba6ea4e438493bf996fff66b7
Cr-Commit-Position: refs/heads/master@{#418402}
==========

[commit-bot: I haz the power, 2016-09-13 23:12:40]

Patchset 2 (id:??) landed as
https://crrev.com/a3987c8b93d3abbba6ea4e438493bf996fff66b7
Cr-Commit-Position: refs/heads/master@{#418402}