Issue 2333133002: Fix cpu_tracing_agent's output on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2333133002: Fix cpu_tracing_agent's output on Mac (Closed)

Created:
4 years, 3 months ago by nednguyen

Modified:
4 years, 2 months ago

Reviewers:

CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
catapult

Visibility:
Public.

More Reviews

Description

Fix cpu_tracing_agent's output on Mac BUG=catapult:#

Patch Set 1 #

Total comments: 2

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py	View		5 chunks	+23 lines, -5 lines	2 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

nednguyen

4 years, 3 months ago (2016-09-13 12:46:22 UTC) #1

https://codereview.chromium.org/2333133002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py
(right):

https://codereview.chromium.org/2333133002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py:142:
'-o', 'pid %cpu %mem command']
The trick is to rearrange the output columns so that command is the last. With
that, we can parse the 1st, 2nd & 3rd column as pid, cpu, mem & leave the rest
to command

https://codereview.chromium.org/2333133002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py:157:
'command': cmd
full command is more useful than name

Expand Messages | Collapse Messages