Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2333113003: Update yandex suggest urls. (Closed)

Created:
4 years, 3 months ago by Alexander Yashkin
Modified:
4 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, vasilii+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update yandex suggest urls. Update yandex suggest urls. Also add {language} param to suggest url. R=pkasting@chromium.org Committed: https://crrev.com/f0055a24dedd836e161308b69acab1e5e198555a Cr-Commit-Position: refs/heads/master@{#419112}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed yandex suggest url, second iteration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/search_engines/prepopulated_engines.json View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Alexander Yashkin
4 years, 3 months ago (2016-09-13 12:36:25 UTC) #1
Peter Kasting
https://codereview.chromium.org/2333113003/diff/1/components/search_engines/prepopulated_engines.json File components/search_engines/prepopulated_engines.json (right): https://codereview.chromium.org/2333113003/diff/1/components/search_engines/prepopulated_engines.json#newcode607 components/search_engines/prepopulated_engines.json:607: "suggest_url": "https://yandex.kz/suggest/suggest-ff.cgi?v=4&uil={language}&part={searchTerms}", What does v=4 do? Removing it seems ...
4 years, 3 months ago (2016-09-13 19:21:11 UTC) #2
Alexander Yashkin
On 2016/09/13 at 19:21:11, pkasting wrote: > https://codereview.chromium.org/2333113003/diff/1/components/search_engines/prepopulated_engines.json > File components/search_engines/prepopulated_engines.json (right): > > https://codereview.chromium.org/2333113003/diff/1/components/search_engines/prepopulated_engines.json#newcode607 ...
4 years, 3 months ago (2016-09-15 08:21:50 UTC) #3
Peter Kasting
LGTM
4 years, 3 months ago (2016-09-15 17:20:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333113003/20001
4 years, 3 months ago (2016-09-16 05:53:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 06:40:10 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 06:42:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0055a24dedd836e161308b69acab1e5e198555a
Cr-Commit-Position: refs/heads/master@{#419112}

Powered by Google App Engine
This is Rietveld 408576698