chrome/browser/ui/tab_helpers.cc - Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 8fb65842f9373c4975f15a8c66b805c8d73c8da0..780a2d5d3a4a46e29c47403d4f186aebc20eefae 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -21,7 +21,7 @@

#include "chrome/browser/history/history_tab_helper.h"

#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/infobars/infobar_service.h"

-#include "chrome/browser/metrics/desktop_engagement/desktop_engagement_observer.h"

+#include "chrome/browser/metrics/desktop_session/desktop_session_observer.h"

#include "chrome/browser/net/net_error_tab_helper.h"

#include "chrome/browser/net/predictor_tab_helper.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"

@@ -238,7 +238,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

#if defined(OS_WIN) || defined(OS_MACOSX) || \

(defined(OS_LINUX) && !defined(OS_CHROMEOS))

- metrics::DesktopEngagementObserver::CreateForWebContents(web_contents);

+ metrics::DesktopSessionObserver::CreateForWebContents(web_contents);

#endif

// --- Feature tab helpers behind flags ---