chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc - Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)

Patch Set: Change name Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc ('K') | « chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc ('k') | chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h "	5 #include "chrome/browser/metrics/desktop_session_duration/chrome_visibility_obse rver.h"

6	6

7 #include "base/memory/singleton.h"	7 #include "base/memory/singleton.h"

8 #include "chrome/browser/chrome_notification_types.h"	8 #include "chrome/browser/chrome_notification_types.h"

9 #include "chrome/browser/ui/browser.h"	9 #include "chrome/browser/ui/browser.h"

10 #include "chrome/browser/ui/browser_list.h"	10 #include "chrome/browser/ui/browser_list.h"

11 #include "chrome/test/base/in_process_browser_test.h"	11 #include "chrome/test/base/in_process_browser_test.h"

12 #include "chrome/test/base/ui_test_utils.h"	12 #include "chrome/test/base/ui_test_utils.h"

13 #include "content/public/browser/notification_service.h"	13 #include "content/public/browser/notification_service.h"

14 #include "content/public/test/test_utils.h"	14 #include "content/public/test/test_utils.h"

15	15

(...skipping 24 matching lines...) Expand all Loading...
40 Browser* incognito_browser = CreateIncognitoBrowser();	40 Browser* incognito_browser = CreateIncognitoBrowser();

41 EXPECT_TRUE(observer.is_active());	41 EXPECT_TRUE(observer.is_active());

42	42

43 CloseBrowserSynchronously(incognito_browser);	43 CloseBrowserSynchronously(incognito_browser);

44 EXPECT_TRUE(observer.is_active());	44 EXPECT_TRUE(observer.is_active());

45	45

46 CloseBrowserSynchronously(new_browser);	46 CloseBrowserSynchronously(new_browser);

47 CloseBrowserSynchronously(browser());	47 CloseBrowserSynchronously(browser());

48 EXPECT_FALSE(observer.is_active());	48 EXPECT_FALSE(observer.is_active());

49 }	49 }

OLD	NEW