Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3319)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java

Issue 2333063002: Record UMA for battery level when precache starts and ends (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java
index 0b8a6d52f322e217a4fbc7a2bbbd2d7994909ae8..37d739c58a4447172430f91fb587ca6fca61f74b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java
@@ -64,7 +64,7 @@ public class PrecacheController {
*/
public static final String CONTINUATION_TASK_TAG = "precache-continuation";
- static final int WAIT_UNTIL_NEXT_PRECACHE_SECONDS = 6 * 60 * 60; // 6 hours.
+ static final int WAIT_UNTIL_NEXT_PRECACHE_SECONDS = 2 * 60; // 6 hours.
sclittle 2016/09/14 16:44:44 You changed this to 2 minutes, was this intentiona
Raj 2016/09/14 16:50:56 Done.
static final int COMPLETION_TASK_MIN_DELAY_SECONDS = 5 * 60; // 5 minutes.
static final int COMPLETION_TASK_MAX_DELAY_SECONDS = 60 * 60; // 1 hour.
static final int MAX_SYNC_SERVICE_INIT_TIMOUT_MS = 5 * 60 * 1000; // 5 minutes
@@ -369,6 +369,7 @@ public class PrecacheController {
recordPeriodicTaskIntervalHistogram();
cancelPrecacheCompletionTask(mAppContext);
}
+ recordBatteryLevelAtStart();
registerDeviceStateReceiver();
acquirePrecachingWakeLock();
startPrecachingAfterSyncInit();
@@ -439,6 +440,7 @@ public class PrecacheController {
if (precachingIncomplete) {
schedulePrecacheCompletionTask(mAppContext);
}
+ recordBatteryLevelAtEnd();
mHandler.removeCallbacks(mTimeoutRunnable);
mAppContext.unregisterReceiver(mDeviceStateReceiver);
releasePrecachingWakeLock();
@@ -543,4 +545,21 @@ public class PrecacheController {
.putLong(PREF_PRECACHE_PERIODIC_TASK_START_TIME_MS, current_start_time_ms)
.apply();
}
+
+ private void recordBatteryLevelAtStart() {
+ mDeviceState.saveCurrentBatteryPercentage(mAppContext);
+
+ // Report battery percentage.
+ RecordHistogram.recordPercentageHistogram(
+ "Precache.BatteryPercentage.Start", mDeviceState.getSavedBatteryPercentage());
+ }
+
+ private void recordBatteryLevelAtEnd() {
+ int delta_percentage = mDeviceState.getCurrentBatteryPercentage(mAppContext)
+ - mDeviceState.getSavedBatteryPercentage();
+ if (delta_percentage >= 0) {
+ RecordHistogram.recordPercentageHistogram(
+ "Precache.BatteryPercentageDiff.End", delta_percentage);
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698