Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2333033002: Deprecation warnings can cite M57/M58/M59 (Closed)

Created:
4 years, 3 months ago by Eric Willigers
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecation warnings can cite M57/M58/M59 Estimated stable dates for M57, M58 and M59 are added. This allows these milestones to be used in deprecation messages. Committed: https://crrev.com/13aff02a4d36c97336474e1ab1410c11fa398f51 Cr-Commit-Position: refs/heads/master@{#419173}

Patch Set 1 #

Patch Set 2 : M59 stable in June #

Patch Set 3 : expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/doppler-deprecated-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 37 (18 generated)
Eric Willigers
4 years, 3 months ago (2016-09-12 22:42:32 UTC) #2
Eric Willigers
4 years, 3 months ago (2016-09-12 23:36:30 UTC) #4
Takashi Toyoshima
LGTM per one nit on the CL description, "M57, M57 and M59" => "M57, M58 ...
4 years, 3 months ago (2016-09-13 05:51:11 UTC) #5
Eric Willigers
+dcheng for OWNERS
4 years, 3 months ago (2016-09-13 06:52:58 UTC) #8
dcheng
rs lgtm
4 years, 3 months ago (2016-09-13 16:07:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333033002/20001
4 years, 3 months ago (2016-09-13 21:04:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/296941)
4 years, 3 months ago (2016-09-13 22:29:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333033002/20001
4 years, 3 months ago (2016-09-14 00:49:25 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/297173)
4 years, 3 months ago (2016-09-14 03:05:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333033002/20001
4 years, 3 months ago (2016-09-14 03:12:06 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/295884)
4 years, 3 months ago (2016-09-14 04:23:19 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333033002/20001
4 years, 3 months ago (2016-09-14 04:28:30 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/297265)
4 years, 3 months ago (2016-09-14 05:43:07 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333033002/40001
4 years, 3 months ago (2016-09-16 03:29:29 UTC) #28
Eric Willigers
> Try jobs failed on following builders: The Release Calendar has M55 hitting stable around ...
4 years, 3 months ago (2016-09-16 03:31:59 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/294390)
4 years, 3 months ago (2016-09-16 07:24:35 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333033002/40001
4 years, 3 months ago (2016-09-16 13:09:50 UTC) #33
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 15:42:33 UTC) #35
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 15:43:56 UTC) #37
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/13aff02a4d36c97336474e1ab1410c11fa398f51
Cr-Commit-Position: refs/heads/master@{#419173}

Powered by Google App Engine
This is Rietveld 408576698