Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2333023004: Cleanup NaCl SDK recipes (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
4 years, 3 months ago
Reviewers:
bradnelson
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Cleanup NaCl SDK recipes Use api.chromium.runhooks() rather than using runhooks wrapper script. Don't pass needless arguments to buildbot_run.py. This brings us one step closer to removing these recipes and merging with nacl/sdk.py. BUG=646185 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c

Patch Set 1 #

Patch Set 2 : . #

Messages

Total messages: 13 (7 generated)
Sam Clegg
4 years, 3 months ago (2016-09-13 22:46:24 UTC) #3
bradnelson
lgtm
4 years, 3 months ago (2016-09-13 22:53:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333023004/1
4 years, 3 months ago (2016-09-13 22:53:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/313e96959e629a10)
4 years, 3 months ago (2016-09-13 23:01:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333023004/20001
4 years, 3 months ago (2016-09-13 23:04:27 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 23:08:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/b46e0087c2dbf12ecd9e...

Powered by Google App Engine
This is Rietveld 408576698