Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2333003002: Changed previews component to be a layered component. (Closed)

Created:
4 years, 3 months ago by sclittle
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, blundell+watchlist_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed previews component to be a layered component. This will make it easier to add a content/ directory to the previews component later. BUG= Committed: https://crrev.com/a8780a99e487b8883d69fcf9e0525d046371e878 Cr-Commit-Position: refs/heads/master@{#419310}

Patch Set 1 #

Patch Set 2 : Rebased on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -817 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/previews/previews_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D components/previews/BUILD.gn View 1 chunk +0 lines, -41 lines 0 comments Download
D components/previews/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
A + components/previews/core/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/previews/core/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/previews/core/previews_data_savings.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/previews/core/previews_data_savings.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/previews/core/previews_data_savings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/previews/core/previews_experiments.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/previews/core/previews_experiments.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/previews/core/previews_experiments_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/previews/core/previews_io_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/previews/core/previews_io_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/previews/core/previews_io_data_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + components/previews/core/previews_ui_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/previews/core/previews_ui_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/previews/core/previews_ui_service_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D components/previews/previews_data_savings.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/previews/previews_data_savings.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D components/previews/previews_data_savings_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D components/previews/previews_experiments.h View 1 chunk +0 lines, -23 lines 0 comments Download
D components/previews/previews_experiments.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D components/previews/previews_experiments_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D components/previews/previews_io_data.h View 1 chunk +0 lines, -56 lines 0 comments Download
D components/previews/previews_io_data.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D components/previews/previews_io_data_unittest.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
D components/previews/previews_ui_service.h View 1 chunk +0 lines, -48 lines 0 comments Download
D components/previews/previews_ui_service.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D components/previews/previews_ui_service_unittest.cc View 1 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
sclittle
4 years, 3 months ago (2016-09-12 21:52:00 UTC) #3
RyanSturm
lgtm
4 years, 3 months ago (2016-09-12 23:50:20 UTC) #4
RyanSturm
lgtm
4 years, 3 months ago (2016-09-12 23:50:21 UTC) #5
sclittle
+dimich for chrome/browser/offline_pages/* +mmenke for chrome/browser/profiles/* +blundell for components/BUILD.gn +miguelg for chrome/browser/BUILD.gn +asvitkine for dependency ...
4 years, 3 months ago (2016-09-13 00:03:13 UTC) #7
mmenke
On 2016/09/13 00:03:13, sclittle wrote: > +dimich for chrome/browser/offline_pages/* > +mmenke for chrome/browser/profiles/* > +blundell ...
4 years, 3 months ago (2016-09-13 01:53:46 UTC) #8
Dmitry Titov
lgtm for chrome/browser/offline_pages/*
4 years, 3 months ago (2016-09-13 04:44:41 UTC) #9
blundell
lgtm
4 years, 3 months ago (2016-09-13 08:32:23 UTC) #10
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-13 16:18:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333003002/1
4 years, 3 months ago (2016-09-16 20:11:26 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/70630) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-16 20:14:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333003002/20001
4 years, 3 months ago (2016-09-16 20:29:42 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 22:39:45 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 22:42:11 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8780a99e487b8883d69fcf9e0525d046371e878
Cr-Commit-Position: refs/heads/master@{#419310}

Powered by Google App Engine
This is Rietveld 408576698