Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 23330005: Replace OS::MemCopy with memcpy in typed array initialization. (Closed)

Created:
7 years, 4 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Replace OS::MemCopy with memcpy in typed array initialization. This is an attempt to fix a weird perf regression on MacOS X 10.6 bot. Perf regression is not reproducible on MacOS X 10.8. This difference in memory-copying routines is the only reasonable difference in the algorithm. We should try and see. R=bmeurer@chromium.org BUG=270642 Committed: https://code.google.com/p/v8/source/detail?r=16245

Patch Set 1 #

Patch Set 2 : One more time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
7 years, 4 months ago (2013-08-20 11:08:15 UTC) #1
Benedikt Meurer
LGTM On a side note: The system memcpy() is pretty much optimal nowadays in nearly ...
7 years, 4 months ago (2013-08-20 11:13:20 UTC) #2
Dmitry Lomov (no reviews)
7 years, 4 months ago (2013-08-20 11:15:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16245.

Powered by Google App Engine
This is Rietveld 408576698